Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133540 / 25.04 / Allow disk list to be filtered by size #11335

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

Result:

Screen.Recording.2025-01-14.at.14.44.55.mov

@AlexKarpov98 AlexKarpov98 self-assigned this Jan 14, 2025
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner January 14, 2025 12:46
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team January 14, 2025 12:46
@bugclerk bugclerk changed the title NAS-133540: Allow disk list to be filtered by size NAS-133540 / 25.04 / Allow disk list to be filtered by size Jan 14, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.75%. Comparing base (0f70118) to head (d94922a).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../disks/components/disk-list/disk-list.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11335   +/-   ##
=======================================
  Coverage   82.74%   82.75%           
=======================================
  Files        1654     1654           
  Lines       59135    59151   +16     
  Branches     6218     6224    +6     
=======================================
+ Hits        48932    48951   +19     
+ Misses      10203    10200    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AlexKarpov98 AlexKarpov98 merged commit 2109ea6 into master Jan 15, 2025
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-133540 branch January 15, 2025 09:05
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants